[PM-16811] - SCIM Invite Users Optimizations

[jrmccannon]

🎟️ Tracking

PM-16811

📔 Objective

The goal of this PR is to improve the Invite Organization User flow from the SCIM POST endpoint. It will be later used to optimize the InviteOrganizationUser flow.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 40.34653% with 241 lines in your changes missing coverage. Please review.

Project coverage is 44.38%. Comparing base (71f2931) to head (4b6eba4).

Files with missing lines	Patch %	Lines
...sers/InviteUsers/InviteOrganizationUsersCommand.cs	10.52%	34 Missing ⚠️
...ers/Validation/InviteOrganizationUserValidation.cs	13.51%	32 Missing ⚠️
...idation/Models/SecretsManagerSubscriptionUpdate.cs	0.00%	25 Missing ⚠️
...viteUsers/Models/InviteOrganizationUsersRequest.cs	0.00%	18 Missing ⚠️
...rs/InviteUsers/Models/OrganizationUserInviteDto.cs	0.00%	17 Missing ⚠️
...s/Validation/SecretsManagerInviteUserValidation.cs	0.00%	16 Missing ⚠️
...eUsers/Models/InviteScimOrganizationUserRequest.cs	0.00%	15 Missing ⚠️
...itwarden_license/src/Scim/Users/PostUserCommand.cs	51.72%	13 Missing and 1 partial ⚠️
...tion/InvitingUserOrganizationProviderValidation.cs	0.00%	12 Missing ⚠️
...Users/InviteUsers/Models/OrganizationUserInvite.cs	78.94%	6 Missing and 2 partials ⚠️
... and 12 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5398      +/-   ##
==========================================
- Coverage   44.43%   44.38%   -0.06%     
==========================================
  Files        1500     1521      +21     
  Lines       69546    69913     +367     
  Branches     6262     6304      +42     
==========================================
+ Hits        30905    31031     +126     
- Misses      37314    37545     +231     
- Partials     1327     1337      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 74a936e6-91d0-4c3b-900a-76b61073764a

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: 74	details Method Post at line 74 of /bitwarden_license/src/Scim/Controllers/v2/UsersController.cs gets a parameter from a user request from Post. This parame... Attack Vector
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 94	details Method Verify at line 94 of /src/Api/AdminConsole/Controllers/OrganizationDomainController.cs gets a parameter from a user request from id. This pa... Attack Vector
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 94	details Method Verify at line 94 of /src/Api/AdminConsole/Controllers/OrganizationDomainController.cs gets a parameter from a user request from orgId. This... Attack Vector

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 649
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 108

[github-actions]

LaunchDarkly flag references

🔍 1 flag added or modified

Name	Key	Aliases found	Info
Optimize Invite User flow to fail fast	pm-16811-optimize-invite-user-flow-to-fail-fast

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud