[PM-12601] Add discount to MSP during creation in Admin Portal

[amorask-bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12601

📔 Objective

This PR adds a selectable discount type to the MSP creation screen in the Bitwarden Admin Portal. The select list options are mapped to Stripe Coupon IDs and those IDs are then stored in the database on the newly created, nullable Provider.DiscountId column.

Then, when the Stripe Customer for the Provider is created, the service checks for the existence of a DiscountId and uses that to attach the related Stripe Coupon to the Provider's Customer.

After this point, the remainder of the platform's functionality with relation to Provider discounts is driven off the Coupon attached to the Provider's customer.

I chose to forego a feature flag for this feature because it requires a database migration anyway and the actual code change is all just small additions that doesn't disrupt existing logic.

📸 Screenshots

Screen.Recording.2025-02-11.at.11.33.58.AM.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 44.56%. Comparing base (f4c37df) to head (1ef0ee6).

Files with missing lines	Patch %	Lines
...dmin/AdminConsole/Views/Providers/CreateMsp.cshtml	0.00%	7 Missing ⚠️
.../Commercial.Core/Billing/ProviderBillingService.cs	94.11%	0 Missing and 1 partial ⚠️
...ation/Services/Implementations/ProviderMigrator.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5391   +/-   ##
=======================================
  Coverage   44.56%   44.56%           
=======================================
  Files        1505     1505           
  Lines       69896    69912   +16     
  Branches     6285     6287    +2     
=======================================
+ Hits        31150    31159    +9     
- Misses      37414    37421    +7     
  Partials     1332     1332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 5d26dd20-6b0d-4822-a040-aea0673cdd9b

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 110	details Method Post at line 110 of /src/Api/AdminConsole/Public/Controllers/GroupsController.cs gets a parameter from a user request from model. This param... Attack Vector
	CSRF	/src/Api/AdminConsole/Controllers/PoliciesController.cs: 168	details Method GetMasterPasswordPolicy at line 168 of /src/Api/AdminConsole/Controllers/PoliciesController.cs gets a parameter from a user request from Get... Attack Vector

Fixed Issues (6)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Billing/Controllers/StripeController.cs: 176
	CSRF	/src/Billing/Controllers/StripeController.cs: 164
	CSRF	/src/Billing/Controllers/RecoveryController.cs: 38
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 164
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 47
	CSRF	/src/Api/Tools/Controllers/ImportCiphersController.cs: 63

[BTreston]

Looks like there's a failing required test related to missing EF migrations.

[amorask-bitwarden]

Looks like there's a failing required test related to missing EF migrations.

@BTreston Completely missed that! Thank you, I've added the migrations.

[BTreston]

Small linter error, otherwise looks good

[BTreston]

I believe a semi-colon at the end here will fix these linter errors.

[amorask-bitwarden]

Gah sorry about that I forgot to run dotnet format for the migrations. Should be good now.

[BTreston]

AC code looks good, thank you!

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
41.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rkac-bw]

lgtm