[PM-14590] Modify Notification database table #5361
+9,330
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5361 +/- ##
==========================================
- Coverage 44.37% 44.30% -0.07%
==========================================
Files 1487 1497 +10
Lines 68595 69212 +617
Branches 6179 6241 +62
==========================================
+ Hits 30438 30665 +227
- Misses 36838 37224 +386
- Partials 1319 1323 +4 ☔ View full report in Codecov by Sentry. |
|
New Issues (25)Checkmarx found the following issues in this Pull Request
Fixed Issues (26)Great job! The following issues were fixed in this Pull Request
|
withinfocus
requested changes
Feb 7, 2025
| @@ -7,6 +7,7 @@ CREATE PROCEDURE [dbo].[Notification_Create] | |||
| @OrganizationId UNIQUEIDENTIFIER, | |||
| @Title NVARCHAR(256), | |||
| @Body NVARCHAR(MAX), | |||
| @TaskId UNIQUEIDENTIFIER = NULL, | |||
There was a problem hiding this comment.
❌ All parameters should get added to the end. We parameterize our invocations, but if that weren't happening this would cause execution issues.
| @@ -8,6 +8,7 @@ CREATE TABLE [dbo].[Notification] | |||
| [OrganizationId] UNIQUEIDENTIFIER NULL, | |||
| [Title] NVARCHAR (256) NULL, | |||
| [Body] NVARCHAR (MAX) NULL, | |||
| [TaskId] UNIQUEIDENTIFIER NULL, | |||
There was a problem hiding this comment.
❌ This should have a foreign key.
|
withinfocus
approved these changes
Feb 7, 2025
withinfocus
reviewed
Feb 7, 2025
| @@ -18,6 +18,7 @@ public class Notification : ITableObject<Guid> | |||
| [MaxLength(256)] | |||
| public string? Title { get; set; } | |||
| public string? Body { get; set; } | |||
| public Guid? TaskId { get; set; } | |||
There was a problem hiding this comment.
⛏️ I like these to be in order too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14590
📔 Objective
We need to modify the Notification entity to have an optional TaskId column.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes