[PM-12491] Create Organization disable command #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabling organizations
…tation in OrganizationService
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5348 +/- ##
==========================================
+ Coverage 44.56% 44.58% +0.02%
==========================================
Files 1505 1506 +1
Lines 69896 69908 +12
Branches 6285 6285
==========================================
+ Hits 31150 31170 +20
+ Misses 37414 37406 -8
Partials 1332 1332 ☔ View full report in Codecov by Sentry. |
cturnbull-bitwarden
previously approved these changes
Jan 30, 2025
|
New Issues (7)Checkmarx found the following issues in this Pull Request
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
jrmccannon
reviewed
Jan 30, 2025
src/Core/AdminConsole/OrganizationFeatures/Organizations/OrganizationDisableCommand.cs
Outdated
Show resolved
Hide resolved
jrmccannon
previously approved these changes
Feb 3, 2025
cyprain-okeke
previously approved these changes
Feb 10, 2025
cturnbull-bitwarden
previously approved these changes
Feb 10, 2025
# Conflicts: # src/Billing/Services/Implementations/SubscriptionUpdatedHandler.cs # src/Core/AdminConsole/Services/IOrganizationService.cs # src/Core/AdminConsole/Services/Implementations/OrganizationService.cs # src/Core/OrganizationFeatures/OrganizationServiceCollectionExtensions.cs
r-tome
dismissed stale reviews from jrmccannon, cyprain-okeke, and cturnbull-bitwarden
via
e4ee2e4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12491
📔 Objective
Extract the
OrganizationService.EnableAsyncmethod into a command.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes