PM-16517: Create personal use plan for additional storage #5205
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,7 +38,7 @@ public Families2019PasswordManagerFeatures() | |||
| HasPremiumAccessOption = true; | |||
|
|
|||
| StripePlanId = "personal-org-annually"; | |||
| StripeStoragePlanId = "storage-gb-annually"; | |||
There was a problem hiding this comment.
Are you changing the existing storage name , what of the users that has subscribed to it. I am not sure you are able to change a product name when it has subscribers in stripe
|
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5205 +/- ##
=======================================
Coverage 43.70% 43.70%
=======================================
Files 1472 1472
Lines 67963 67963
Branches 6161 6161
=======================================
Hits 29703 29703
Misses 36963 36963
Partials 1297 1297 ☔ View full report in Codecov by Sentry. |
cturnbull-bitwarden
approved these changes
Jan 3, 2025
…rate-product-personal-use' into PM-16517-Additional-storage-separate-product-personal-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16517
📔 Objective
Separate price & product for personal use Password Manager plans when additional storage is purchased.
To validate still internally whether we update existing subscriptions when listening to webhooks or we update them all at once in bulk.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes