Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2551] Fix migration files #4854

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

When regenerating the migration files to bring them in line with the current date, I forgot to remove the generated code from the snapshot and thus I generated empty migration files. This resolves that.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner October 4, 2024 15:47
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.57%. Comparing base (0496085) to head (310fafc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4854   +/-   ##
=======================================
  Coverage   41.57%   41.57%           
=======================================
  Files        1357     1357           
  Lines       64056    64056           
  Branches     5891     5891           
=======================================
  Hits        26631    26631           
  Misses      36208    36208           
  Partials     1217     1217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amorask-bitwarden amorask-bitwarden merged commit c449886 into main Oct 4, 2024
53 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/AC-2551/fix-migration-files branch October 4, 2024 16:05
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One – Scan Summary & Details52b2a7d1-8dff-4395-9d68-0ab8c218ef25

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants