Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11404] Account Deprovisioning: Prevent a verified user from purging their vault #4853

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Oct 4, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11404

📔 Objective

If the Account Deprovisioning feature flag is enabled then prevent organization managed users from purging their vault.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.57%. Comparing base (a1e4e47) to head (2654a17).

Files with missing lines Patch % Lines
src/Api/Vault/Controllers/CiphersController.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4853      +/-   ##
==========================================
- Coverage   41.57%   41.57%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       64056    64060       +4     
  Branches     5891     5892       +1     
==========================================
  Hits        26631    26631              
- Misses      36208    36212       +4     
  Partials     1217     1217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One – Scan Summary & Details258b4cef-f4d7-44c2-b165-652997f244dd

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /src/Admin/Startup.cs: 41 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 176
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProvidersController.cs: 274

@r-tome r-tome marked this pull request as ready for review October 7, 2024 09:37
@r-tome r-tome requested a review from a team as a code owner October 7, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant