[PM-11162] Assign to Collection Permission Update

[Jingo88]

🎟️ Tracking

PM-11162

📔 Objective

Users with Can Edit Except Password will not be allowed to assign collections to ciphers

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – d4122b94-34bc-4330-bd9c-9985fb7b372b

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1138	Attack Vector
	Privacy_Violation	/src/Api/Vault/Controllers/CiphersController.cs: 959	Attack Vector
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 951	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 189
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 140
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 121
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 107
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 107
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 121
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 929
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 530
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1085
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 647
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 676
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 189
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 140
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 170
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 155
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 574
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 553
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 530
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 155
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 170
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 603

[shane-melton]

Changes look good, but looks like we need to update CipherController tests.

[codecov]

Codecov Report

Attention: Patch coverage is 3.33333% with 29 lines in your changes missing coverage. Please review.

Project coverage is 41.55%. Comparing base (f3f81de) to head (0df254a).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Api/Vault/Controllers/CiphersController.cs	3.33%	29 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4844      +/-   ##
==========================================
- Coverage   42.01%   41.55%   -0.46%     
==========================================
  Files        1337     1357      +20     
  Lines       63273    64084     +811     
  Branches     5836     5895      +59     
==========================================
+ Hits        26585    26631      +46     
- Misses      35471    36236     +765     
  Partials     1217     1217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.