Skip to content
Scan

Split Organization.LimitCollectionCreationDeletion into two separate business rules #3727

Sign in to view logs

Split Organization.LimitCollectionCreationDeletion into two separate business rules

Split Organization.LimitCollectionCreationDeletion into two separate business rules #3727

Triggered via pull request October 4, 2024 18:32
@addisonbeckaddisonbeck
synchronize #4730
Status Success
Total duration 4m 19s
Artifacts –

scan.yml

on: pull_request_target
Check PR run  /  Check
2s
Check PR run / Check
SAST scan
3m 58s
SAST scan
Quality scan
3m 54s
Quality scan
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Bit.Api.Test.Vault.AuthorizationHandlers.BulkCollectionAuthorizationHandlerTests ► CanCreateAsync_WhenMissingOrgAccess_NoSuccess(userId: f581f2ec-a829-4bd2-9ae5-80641c649e6d, organization: CurrentContextOrganization { AccessSecretsManager = True, Id = ...: test/Api.Test/Vault/AuthorizationHandlers/BulkCollectionAuthorizationHandlerTests.cs#L132
Failed test found in: test/Api.Test/TestResults/oss-test-results.trx Error: Assert.False() Failure Expected: False Actual: True
Bit.Api.Test.Vault.AuthorizationHandlers.BulkCollectionAuthorizationHandlerTests ► HandleRequirementAsync_Provider_Success(sutProvider: SutProvider`1 { Sut = BulkCollectionAuthorizationHandler { }, SutType = typeof(Bit.Api.Vault.AuthorizationHandlers.C...: test/Api.Test/Vault/AuthorizationHandlers/BulkCollectionAuthorizationHandlerTests.cs#L1301
Failed test found in: test/Api.Test/TestResults/oss-test-results.trx Error: NSubstitute.Exceptions.ReceivedCallsException : Expected to receive a call matching: ProviderUserForOrgAsync(9e329003-4b8a-4e4c-a691-21735f834b0a) Actually received no matching calls.
Quality scan: src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L11
'ProviderInitiateDeleteModel.WebVaultUrl' hides inherited member 'BaseMailModel.WebVaultUrl'. Use the new keyword if hiding was intended.
Quality scan: src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L14
'ProviderInitiateDeleteModel.SiteName' hides inherited member 'BaseMailModel.SiteName'. Use the new keyword if hiding was intended.
Quality scan: src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/UpdateOrganizationUserCommand.cs#L118
Possible null reference argument for parameter 'collections' in 'Task IOrganizationUserRepository.ReplaceAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections)'.
Quality scan: src/Core/Billing/Services/Implementations/PaymentHistoryService.cs#L14
Parameter 'logger' is unread.
Quality scan: src/Infrastructure.Dapper/AdminConsole/Repositories/OrganizationRepository.cs#L180
Possible null reference return.
Quality scan: test/Core.Test/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteManagedOrganizationUserAccountCommandTests.cs#L68
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Quality scan: bitwarden_license/src/Scim/Controllers/v2/UsersController.cs#L50
ModelState.IsValid should be checked in controller actions. (https://rules.sonarsource.com/csharp/RSPEC-6967)
Quality scan: bitwarden_license/src/Scim/Controllers/v2/UsersController.cs#L61
ModelState.IsValid should be checked in controller actions. (https://rules.sonarsource.com/csharp/RSPEC-6967)
Quality scan: bitwarden_license/src/Scim/Controllers/v2/UsersController.cs#L79
ModelState.IsValid should be checked in controller actions. (https://rules.sonarsource.com/csharp/RSPEC-6967)
Quality scan: bitwarden_license/src/Scim/Controllers/v2/UsersController.cs#L87
ModelState.IsValid should be checked in controller actions. (https://rules.sonarsource.com/csharp/RSPEC-6967)