Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-507 | Python 3.9 #73

Merged
merged 17 commits into from
Sep 24, 2024
Merged

PAS-507 | Python 3.9 #73

merged 17 commits into from
Sep 24, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Sep 17, 2024

Ticket

Description

Python 3.8 is reaching EOL, and we need to bump the minimum required version to 3.9.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner September 17, 2024 12:36
@jonashendrickx jonashendrickx changed the title Feature/py39 Python 3.9 Sep 17, 2024
@jonashendrickx jonashendrickx changed the title Python 3.9 PAS-507 | Python 3.9 Sep 17, 2024
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but missing GH CD workflow and readme updates

examples/streamlit/pyproject.toml Outdated Show resolved Hide resolved
examples/flask/pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
examples/flask/pyproject.toml Show resolved Hide resolved
examples/flask/pyproject.toml Show resolved Hide resolved
examples/streamlit/pyproject.toml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonashendrickx jonashendrickx merged commit 8e20359 into main Sep 24, 2024
6 checks passed
@jonashendrickx jonashendrickx deleted the feature/py39 branch September 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants