Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-563 | RPID is not mapped correctly when retrieving credentials #151

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Aug 26, 2024

We would need a new release after merging this.

@jonashendrickx jonashendrickx requested a review from a team as a code owner August 26, 2024 13:34
@jonashendrickx jonashendrickx enabled auto-merge (squash) August 26, 2024 13:34
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.88%. Comparing base (c8beda6) to head (1cc8117).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Passwordless/Models/Credential.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   59.88%   59.88%           
=======================================
  Files          43       43           
  Lines         688      688           
  Branches       56       56           
=======================================
  Hits          412      412           
  Misses        272      272           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit f6c87a1 into main Aug 26, 2024
7 checks passed
@jonashendrickx jonashendrickx deleted the PAS-563-RPID-is-is-null-on-credential-cards branch August 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants