Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Workflow Linter #365

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix Workflow Linter #365

merged 2 commits into from
Feb 12, 2025

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Feb 12, 2025

📔 Objective

This PR fixes the workflow linter so that the changed-workflows step functions correctly. It further fixes the if keys on all the remaining steps, since the output all_change_files_count of the tj-actions/changes-files action is a string.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Feb 12, 2025
@vgrassia vgrassia requested a review from a team as a code owner February 12, 2025 15:54
@vgrassia vgrassia merged commit 7ea7455 into main Feb 12, 2025
6 checks passed
@vgrassia vgrassia deleted the fix-step-order branch February 12, 2025 16:08
Copy link

Logo
Checkmarx One – Scan Summary & Details71a2bc42-2e3f-4ff9-9386-9492e71e4608

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants