Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-564] Agalles/scan examples #363

Merged
merged 11 commits into from
Feb 12, 2025
Merged

BRE-564] Agalles/scan examples #363

merged 11 commits into from
Feb 12, 2025

Conversation

AmyLGalles
Copy link
Contributor

@AmyLGalles AmyLGalles commented Feb 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-564?atlOrigin=eyJpIjoiYTEwY2VkYmFlMTZiNGNlZDk0N2I1OWI1ZTk0ZTdlZjgiLCJwIjoiaiJ9

📔 Objective

In order to keep workflow exmples up to date, we're regularly scanning them with the workflow linter. The example workflows include actions that weren't being used in this repository, so I added them in a subdirectory to support testing.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles requested a review from a team as a code owner February 11, 2025 15:25
Copy link

github-actions bot commented Feb 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsc2407d2f-0a01-477c-a955-bab4cd32e37f

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-22150 Npm-undici-5.28.2 Vulnerable Package

@AmyLGalles AmyLGalles merged commit 7649f13 into main Feb 12, 2025
6 checks passed
@AmyLGalles AmyLGalles deleted the agalles/scan-examples branch February 12, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants