Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1597] - Use Action to Get Changed Files #237

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Jan 17, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿšง Type of change

  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

  • Using bash script to get changed files is inconsistent when the workflow is called from other repo. We need that step to be consistent because we are now requiring the linter workflow to run from an organizational level. This means it will trigger on every PR even if no file is changed from .github/workflows/** path.

๐Ÿ“‹ Code changes

  • .github/workflows/workflow-linter.yml: Remove the Bash script test for an action

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner January 17, 2024 15:37
@Eeebru Eeebru enabled auto-merge (squash) January 17, 2024 16:18
@Eeebru Eeebru merged commit aa000ec into main Jan 17, 2024
1 check passed
@Eeebru Eeebru deleted the DEVOPS-1597-edit-linter-workflow-to-run-anywhere-3 branch January 17, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants