Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1651] Update the QA deployment alert at the start #215

Merged

Conversation

michalchecinski
Copy link
Contributor

@michalchecinski michalchecinski commented Nov 28, 2023

🎟️ Tracking

https://bitwarden.atlassian.net/browse/DEVOPS-1651

🚧 Type of change

  • 🚀 New feature development
  • 🤖 Build/deploy pipeline (DevOps)

📔 Objective

📋 Code changes

  • report-deployment-status-to-slack/action.yml: Change failure (true/false) input to event (string: start, failure, success). Add URL parameter. Add step with start event message.
  • .github/actions/test-report-deployment-status-to-slack.yml: Change inputs to match new ones. Add start message test.

📸 Screenshots

New starting deployment message. I've tried to format it with a link under string, but it didn't work, and I don't want to spend hours to getting this to work.
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner November 28, 2023 13:48
@michalchecinski michalchecinski merged commit 4b5492c into main Nov 29, 2023
4 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1651-Update-the-QA-deployment-alert-at-the-start branch November 29, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants