Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1578] Automate QA deploy messages #204

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/DEVOPS-1578

🚧 Type of change

  • 🚀 New feature development
  • 🤖 Build/deploy pipeline (DevOps)

📔 Objective

Add github action that can be used across our repos to report deployment status to Slack.

📋 Code changes

  • .github/workflows/test-report-deployment-status-to-slack.yml: Workflow to test the action
  • report-deployment-status-to-slack/action.yml Composite action that's sending Slack message about deployment status.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski requested a review from a team as a code owner October 26, 2023 14:15
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 26, 2023

Logo
Checkmarx One – Scan Summary & Details2379f59d-40d1-4174-879c-6eb18b389431

No New Or Fixed Issues Found

@mimartin12
Copy link
Contributor

Quick question on this one.
What was the benefit moving from a reusable workflow to a composite workflow?

@Eeebru
Copy link
Contributor

Eeebru commented Oct 26, 2023

Maybe change the name of the action folder to report-deployment-status-to-slack

@michalchecinski
Copy link
Contributor Author

@mimartin12 I wanted to keep it consistent across gh-actions repo. I could quickly revert to a reusable workflow if needed (have the file on hand).

@michalchecinski
Copy link
Contributor Author

@Eeebru I think the name of the folder is the same as yours. But maybe my eyesight is playing tricks on me 😅

@Eeebru
Copy link
Contributor

Eeebru commented Oct 27, 2023

  • Build/deploy pipeline (DevOps)

@michalchecinski test-report-deployment-status-to-slack -> report-deployment-status-to-slack

@michalchecinski
Copy link
Contributor Author

@Eeebru Ah, okay. But this is a test of the workflow, so I followed our naming from other like test-download-artifacts.yml or test-release-version-check.yml.

@michalchecinski michalchecinski enabled auto-merge (squash) October 27, 2023 15:45
@michalchecinski michalchecinski merged commit d336bf2 into master Nov 6, 2023
4 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1578-Automate-QA-Deploy-messages branch November 6, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants