Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linter comment rule for Renovate #182

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Aug 2, 2023

๐ŸŽŸ๏ธ Tracking

All of the actions in our workflows that are updated by Renovate use a single space before comments. The workflow linter rule has been updated to reflect that.

๐Ÿšง Type of change

  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

Update the workflow linter to stop producing warnings on single spaces before comments.

๐Ÿ“‹ Code changes

  • lint-workflow/.yamllint.yml: Update the min-spaces-from-content setting under the comments rule.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vgrassia vgrassia requested a review from a team as a code owner August 2, 2023 18:13
@vgrassia vgrassia self-assigned this Aug 2, 2023
@vgrassia vgrassia enabled auto-merge (squash) August 2, 2023 18:14
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 21829f7d-7ad3-4553-aa20-ec744dd9c65f

No New Or Fixed Issues Found

@vgrassia vgrassia merged commit f096207 into master Aug 7, 2023
1 check passed
@vgrassia vgrassia deleted the update-linter-rules branch August 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants