Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty format generated F-droid files #43

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Pretty format generated F-droid files #43

merged 1 commit into from
Sep 21, 2024

Conversation

SaintPatrck
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Internal change

๐Ÿ“” Objective

Regenerate F-droid files with the --pretty flag. This prevents unnecessary changes from appearing in automated updates.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner September 20, 2024 21:11
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 85e6b354-1ecc-4fac-a9f1-1dbd77020d36

No New Or Fixed Issues Found

@vvolkgang vvolkgang merged commit 664f789 into main Sep 21, 2024
5 checks passed
@vvolkgang vvolkgang deleted the pretty-format branch September 21, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants