popup persistance usage examples #9911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing; add route guard with warning dialog
willmartian
changed the base branch from
main
to
ps/PM-3530/popup-view-persistence
|
No New Or Fixed Issues Found |
|
@shane-melton & @djsmith85, any thoughts on this API? More context in the body of #9556 |
willmartian
added
hold
willmartian
commented
Jul 2, 2024
| /** All available cipher filters */ | ||
| export type PopupListFilter = { | ||
| organization: Organization | null; | ||
| collection: Collection | null; | ||
| collection: CollectionView | null; |
There was a problem hiding this comment.
Collection doesn't have a fromJSON method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This PR implements #9556 in a few places in the popup.
📸 Screenshots
Screen.Recording.2024-07-02.at.9.58.27.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes