Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9364] Copy for Aggregate auto-scaling invoices for Teams and Enterprise customers #9875

Merge branch 'main' into pm-9364-copy-for-aggregate-auto-scaling-invoโ€ฆ

cd5ed05
Select commit
Loading
Failed to load commit list.
Merged

[PM-9364] Copy for Aggregate auto-scaling invoices for Teams and Enterprise customers #9875

Merge branch 'main' into pm-9364-copy-for-aggregate-auto-scaling-invoโ€ฆ
cd5ed05
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 1, 2024 in 39s

CodeScene PR Check

โŒ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.13 (8.85 -> 8.72)

  • Declining Code Health: 2 findings(s) ๐Ÿšฉ

View detailed results in CodeScene

Details

๐Ÿšฉ Declining Code Health (highest to lowest):

  • Complex Method organization-subscription-cloud.component.ts: OrganizationSubscriptionCloudComponent.getsubscriptionDesc
  • Bumpy Road Ahead organization-subscription-cloud.component.ts: OrganizationSubscriptionCloudComponent.getsubscriptionDesc

Annotations

Check warning on line 324 in apps/web/src/app/billing/organizations/organization-subscription-cloud.component.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

โŒ Getting worse: Complex Method

OrganizationSubscriptionCloudComponent.getsubscriptionDesc increases in cyclomatic complexity from 11 to 17, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 324 in apps/web/src/app/billing/organizations/organization-subscription-cloud.component.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

โŒ New issue: Bumpy Road Ahead

OrganizationSubscriptionCloudComponent.getsubscriptionDesc has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.