Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13889] - clear cipher cache after deleting a collection #12686

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13889

📔 Objective

This PR fixes an issue where the cipher's collectionId wasn't being cleared if the collection was deleted while inside the collection. Manually clearing the cache fixes the issue. I'm open to suggestion if there's a more elegant way of solving this issue!

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 4, 2025 01:45
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.14%. Comparing base (bb61b3d) to head (50a9dad).
Report is 21 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12686      +/-   ##
==========================================
- Coverage   34.14%   34.14%   -0.01%     
==========================================
  Files        2937     2937              
  Lines       90340    90341       +1     
  Branches    16963    16963              
==========================================
  Hits        30846    30846              
- Misses      57039    57040       +1     
  Partials     2455     2455              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Logo
Checkmarx One – Scan Summary & Details1318b398-7df8-46f3-be20-2d2c7a6da5a8

No New Or Fixed Issues Found

@jaasen-livefront
Copy link
Collaborator Author

@cd-bitwarden Could I please get a review on this. Thank you!!

Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, nice work!

@jaasen-livefront jaasen-livefront merged commit 2271062 into main Jan 9, 2025
38 of 39 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-13889 branch January 9, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants