[PM-16699] Improve decrypt failure logging

[quexten]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16699

📔 Objective

Improves logging by providing context to where the encryption failure happens (i.e what cipher, what key, what encrypting key).

Also cleans up some of the very-old promise-based decrypt logic, which is both hard to read, but also slower to execute.

📸 Screenshots

Screen.Recording.2025-01-03.at.19.26.32.mov

Screen.Recording.2025-01-03.at.18.59.18.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 5f328bf6-bfed-43bf-897a-70c83d9f0fe0

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 276

[codecov]

Codecov Report

Attention: Patch coverage is 71.15385% with 15 lines in your changes missing coverage. Please review.

Project coverage is 33.81%. Comparing base (1e6471b) to head (75da4fb).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
libs/common/src/vault/models/domain/cipher.ts	33.33%	10 Missing ⚠️
...ervices/master-password/master-password.service.ts	0.00%	2 Missing ⚠️
libs/key-management/src/key.service.ts	0.00%	2 Missing ⚠️
...bs/common/src/platform/models/domain/enc-string.ts	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12681      +/-   ##
==========================================
+ Coverage   33.74%   33.81%   +0.06%     
==========================================
  Files        2918     2917       -1     
  Lines       90994    90816     -178     
  Branches    17200    17169      -31     
==========================================
+ Hits        30703    30706       +3     
+ Misses      57891    57708     -183     
- Partials     2400     2402       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.