Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15557] Log missing Cipher_ClientViewed event in Web #12669

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Jan 2, 2025

🎟️ Tracking

PM-15557

📔 Objective

Log the Ciphever_ClientViewed event when the VaultItemDialog in Web opens.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Details7ee18cda-620c-41bb-b12c-cfa62abe65f6

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.73%. Comparing base (9807b33) to head (55eac18).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/vault-item-dialog/vault-item-dialog.component.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12669   +/-   ##
=======================================
  Coverage   33.73%   33.73%           
=======================================
  Files        2918     2918           
  Lines       91001    91005    +4     
  Branches    17201    17202    +1     
=======================================
+ Hits        30696    30698    +2     
- Misses      57905    57906    +1     
- Partials     2400     2401    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shane-melton shane-melton merged commit 828a7fe into main Jan 6, 2025
41 checks passed
@shane-melton shane-melton deleted the vault/pm-15557/missing-web-event-logs branch January 6, 2025 16:42
shane-melton added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants