Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13207] Detect incompatible locale changes - test #11426

Draft
wants to merge 5 commits into
base: km/beeep-detecting-messages-modified-keys
Choose a base branch
from

Conversation

mzieniukbw
Copy link
Contributor

🎟️ Tracking

DO NOT MERGE - testing #11425

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw changed the base branch from main to km/beeep-detecting-messages-modified-keys October 5, 2024 07:27
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Logo
Checkmarx One – Scan Summary & Details72e791ec-bbc3-4913-b9de-b80229c09bd6

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.28%. Comparing base (e94cab2) to head (53071d6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                              Coverage Diff                              @@
##           km/beeep-detecting-messages-modified-keys   #11426      +/-   ##
=============================================================================
- Coverage                                      33.29%   33.28%   -0.02%     
=============================================================================
  Files                                           2731     2729       -2     
  Lines                                          85549    85561      +12     
  Branches                                       16318    16320       +2     
=============================================================================
- Hits                                           28487    28477      -10     
- Misses                                         54804    54822      +18     
- Partials                                        2258     2262       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mzieniukbw mzieniukbw changed the title km/beeep-detecting-messages-modified-keys-test [PM-13207] Detect incompatible locale changes - test Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant