Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13184] Filter out specific-nodes within TreeWalker query #11415

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cagonzalezcs
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13184

๐Ÿ“” Objective

These changes incorporate a preemptive filtering of nodes that are not likely to have ShadowDOM elements within the TreeWalker query used in collection of page details. It filters out nodes such as svg, head, video, audio, etc...

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@cagonzalezcs cagonzalezcs requested a review from a team as a code owner October 4, 2024 16:12
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (d7d7426) to head (d7785ef).

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...browser/src/autofill/services/dom-query.service.ts 50.00% 1 Missing and 2 partials โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11415      +/-   ##
==========================================
- Coverage   33.26%   33.25%   -0.01%     
==========================================
  Files        2729     2729              
  Lines       85524    85527       +3     
  Branches    16314    16315       +1     
==========================================
- Hits        28449    28444       -5     
- Misses      54816    54823       +7     
- Partials     2259     2260       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 71f51b65-9206-4382-94ec-a5230727ba00

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant