Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11205] updating empty state description to match figma #11414

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cd-bitwarden
Copy link
Contributor

🎟️ Tracking


📔 Objective

updating message file and using a new message for empty state

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cd-bitwarden cd-bitwarden requested a review from a team as a code owner October 4, 2024 15:54
@cd-bitwarden cd-bitwarden changed the title PM-11205 updating empty state description to match figma [PM-11205] updating empty state description to match figma Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.29%. Comparing base (bdf91e2) to head (8c042c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11414   +/-   ##
=======================================
  Coverage   33.29%   33.29%           
=======================================
  Files        2731     2731           
  Lines       85549    85549           
  Branches    16318    16318           
=======================================
  Hits        28480    28480           
  Misses      54811    54811           
  Partials     2258     2258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One – Scan Summary & Details7684f013-5680-4625-ae65-7ec75f5eca61

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant