Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPC proxy selection in prod when using ELECTRON_IS_DEV #11412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dani-garcia
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

When running the desktop app in dev mode, we force the selection of IPC proxy binary to be the target/debug artifacts. This is fine when using npm run electron, but will fail when using the production builds and setting the ELECTRON_IS_DEV=1 environment variable.

By changing the behavior to check if the debug artifact exists first and falling back to the prod artifact, we allow this to work regardless of how the isDev flag got activated.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia requested review from a team and coroiu October 4, 2024 15:44
@dani-garcia dani-garcia marked this pull request as ready for review October 4, 2024 15:45
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.26%. Comparing base (f82563e) to head (bf243d2).
Report is 4 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/main/native-messaging.main.ts 0.00% 3 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11412      +/-   ##
==========================================
- Coverage   33.27%   33.26%   -0.02%     
==========================================
  Files        2729     2729              
  Lines       85568    85526      -42     
  Branches    16319    16315       -4     
==========================================
- Hits        28477    28449      -28     
+ Misses      54830    54818      -12     
+ Partials     2261     2259       -2     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 0ec56f36-db74-4469-a700-a75a706739a3

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant