[PM-13170] Enable use of new generators on web #11405
Open
+69
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11405 +/- ##
==========================================
+ Coverage 33.28% 33.29% +0.01%
==========================================
Files 2729 2730 +1
Lines 85559 85576 +17
Branches 16316 16319 +3
==========================================
+ Hits 28475 28490 +15
- Misses 54823 54825 +2
Partials 2261 2261 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
audreyality
reviewed
Oct 4, 2024
| <app-header></app-header> | ||
|
|
||
| <bit-container> | ||
| <!-- Will get replaced with <tools-credential-generator /> once https://github.com/bitwarden/clients/pull/11398 has been merged --> |
There was a problem hiding this comment.
⛏️ I've been calling out things to address in later commits using FIXME: xyz. That way it's easy to find tech debt with grep.
There was a problem hiding this comment.
Addressed with ff18d01
audreyality
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13170
📔 Objective
Create a web-specific hosting component for the new credential-generator. Temporarily, this is going to use the new password-generator component, but will be replaced once #11398 has merged.
The swap is guarded by a feature flag, so this can be merged without affecting current production.
📸 Screenshots
Before
After (temporary)
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes