[PM-12389] Vault Item Dialog Fixes

[shane-melton]

🎟️ Tracking

PM-12389

📔 Objective

• Hide the Delete button when adding or cloning a new cipher.
• Ensure decrypted collections and folders are available before opening the dialog.
  • Before this change, the collections dropdown would sometimes be empty if coming from a direct link to edit an item.

📸 Screenshots

Hidden delete button when creating a cipher

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.27%. Comparing base (f2d3311) to head (b4b16de).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...s/vault-item-dialog/vault-item-dialog.component.ts	0.00%	4 Missing ⚠️
...orm/services/default-cipher-form-config.service.ts	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11374      +/-   ##
==========================================
- Coverage   33.28%   33.27%   -0.01%     
==========================================
  Files        2729     2729              
  Lines       85559    85575      +16     
  Branches    16316    16320       +4     
==========================================
+ Hits        28475    28477       +2     
- Misses      54823    54837      +14     
  Partials     2261     2261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 78285535-4aa9-4dbf-ab20-1fc5b8bf57c9

Fixed Issues

Severity	Issue	Source File / Package
	Client_JQuery_Deprecated_Symbols	/libs/importer/src/services/import.service.ts: 459

[gbubemismith]

Looks good!

[shane-melton]

@gbubemismith Thanks for the review! I just had one more edge case to fix when cloning a cipher.