Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12718] Keyboard accessible trash links #11351

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

nick-livefront
Copy link
Collaborator

@nick-livefront nick-livefront commented Oct 1, 2024

🎟️ Tracking

PM-12718

📔 Objective

I was so focused on the virtual scrolling fixes in #11338, that I forgot about the trash page completely.

  • Updating the trash page to use a button element rather than anchor element. An anchor without an href attribute is not keyboard accessible.

📸 Screenshots

Trash Page
Screen.Recording.2024-10-01.at.3.45.00.PM.mov

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.25%. Comparing base (97a97c4) to head (da7b076).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11351      +/-   ##
==========================================
- Coverage   33.25%   33.25%   -0.01%     
==========================================
  Files        2732     2732              
  Lines       85545    85545              
  Branches    16304    16304              
==========================================
- Hits        28451    28444       -7     
- Misses      54838    54845       +7     
  Partials     2256     2256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Logo
Checkmarx One – Scan Summary & Detailse19cbb4b-80e0-4503-9deb-67268b7e104e

No New Or Fixed Issues Found

@nick-livefront nick-livefront merged commit af231b3 into main Oct 2, 2024
27 checks passed
@nick-livefront nick-livefront deleted the vault/pm-12718/trash-keyboard branch October 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants