[PM-12982] Bugfix - Fix incorrect handling of the first day of the next month is isCardExpired

[jprusik]

🎟️ Tracking

PM-12982

📔 Objective

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[jprusik]

original code is correctly getting the last day of the card month at exactly midnight (00:00:00), but now is currently after that. We actually want to see if the current moment is on or after the first moment of the next month after the expiry month (e.g. the 1st of the next month).

[jprusik]

(I think my original intent here had been to see if the current moment was greater than the last moment of the expiry month)

[github-actions]

Checkmarx One – Scan Summary & Details – 05ee604a-03f4-40b0-9144-64a34abf0b77

No New Or Fixed Issues Found

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.28%. Comparing base (0ecdd46) to head (a84268a).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11337      +/-   ##
==========================================
+ Coverage   33.25%   33.28%   +0.02%     
==========================================
  Files        2731     2731              
  Lines       85298    85324      +26     
  Branches    16226    16229       +3     
==========================================
+ Hits        28364    28397      +33     
+ Misses      54676    54669       -7     
  Partials     2258     2258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.