Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-12732] - fix new send button #11266

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[PM-12732] - fix new send button #11266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7cf16
fix new send button
jaasen-livefront Sep 26, 2024
e5a73da
simplify logic. use static class name where possible
jaasen-livefront Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/browser/src/tools/popup/send-v2/send-v2.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@
<bit-no-items [icon]="noItemIcon" class="tw-text-main">
<ng-container slot="title">{{ "sendsNoItemsTitle" | i18n }}</ng-container>
<ng-container slot="description">{{ "sendsNoItemsMessage" | i18n }}</ng-container>
<tools-new-send-dropdown *ngIf="!sendsDisabled" slot="button"></tools-new-send-dropdown>
<tools-new-send-dropdown
[hideIcon]="true"
*ngIf="!sendsDisabled"
slot="button"
></tools-new-send-dropdown>
</bit-no-items>
</div>

Expand Down
4 changes: 2 additions & 2 deletions libs/tools/send/send-ui/src/new-send-dropdown/new-send-dropdown.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<button bitButton [bitMenuTriggerFor]="itemOptions" buttonType="primary" type="button">
<i class="bwi bwi-plus-f" aria-hidden="true"></i>
{{ "new" | i18n }}
<i *ngIf="!hideIcon" class="bwi bwi-plus-f" aria-hidden="true"></i>
{{ (hideIcon ? "createSend" : "new") | i18n }}
</button>
<bit-menu #itemOptions>
<a type="button" bitMenuItem (click)="newItemNavigate(sendType.Text)">
Expand Down
4 changes: 3 additions & 1 deletion libs/tools/send/send-ui/src/new-send-dropdown/new-send-dropdown.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { CommonModule } from "@angular/common";
import { Component, OnInit } from "@angular/core";
import { Component, Input, OnInit } from "@angular/core";

Check warning on line 2 in libs/tools/send/send-ui/src/new-send-dropdown/new-send-dropdown.component.ts

View check run for this annotation

Codecov / codecov/patch

libs/tools/send/send-ui/src/new-send-dropdown/new-send-dropdown.component.ts#L2 

Added line #L2 was not covered by tests
import { Router, RouterLink } from "@angular/router";
import { firstValueFrom } from "rxjs";

Expand All @@ -15,6 +15,8 @@
imports: [JslibModule, CommonModule, ButtonModule, RouterLink, MenuModule, BadgeModule],
})
export class NewSendDropdownComponent implements OnInit {
@Input() hideIcon: boolean = false;

Check warning on line 18 in libs/tools/send/send-ui/src/new-send-dropdown/new-send-dropdown.component.ts

View check run for this annotation

Codecov / codecov/patch

libs/tools/send/send-ui/src/new-send-dropdown/new-send-dropdown.component.ts#L18 

Added line #L18 was not covered by tests

sendType = SendType;

hasNoPremium = false;
Expand Down
Loading