Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12617] native-messaging: Add chromium support #11230

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

alexyao2015
Copy link
Contributor

@alexyao2015 alexyao2015 commented Sep 25, 2024

Tracking

https://bitwarden.atlassian.net/browse/PM-12617

📔 Objective

Add support for system authentication support in Chromium on linux.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-12617

@bitwarden-bot bitwarden-bot changed the title native-messaging: Add chromium support [PM-12617] native-messaging: Add chromium support Sep 25, 2024
@quexten quexten self-assigned this Sep 25, 2024
@quexten
Copy link
Contributor

quexten commented Sep 25, 2024

Changes look good, though I feel follow-up work is needed so that no PR is needed for every single browser. Thank you for the PR!

@alexyao2015
Copy link
Contributor Author

I don't see a way to automatically support every chromium based browser because they all have their profile in different directories.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

@quexten
Copy link
Contributor

quexten commented Sep 25, 2024

Seems the CLAassistant was broken for a while, @alexyao2015 could you sign the CLA? Then I can hand this off to QA and get it merged.
You were too fast. Thank you!

Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs QA now.

@quexten
Copy link
Contributor

quexten commented Oct 1, 2024

QA passed; merging. Thanks again for the PR!

@quexten quexten merged commit 256c6ae into bitwarden:main Oct 1, 2024
63 of 70 checks passed
@alexyao2015 alexyao2015 deleted the fix/chromium-messaging branch October 1, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants