Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11199] added permission labels to ciphers in AC #11210

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Sep 23, 2024

🎟️ Tracking

PM-11199

📔 Objective

  • Adding Permission Labels to Ciphers in AC.
  • If a cipher belongs to multiple collections make sure the label shows the highest lvl permission

📸 Screenshots

PM-11199

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner September 23, 2024 22:36
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 33.24%. Comparing base (e6ff647) to head (aef4a98).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mponents/vault-items/vault-cipher-row.component.ts 0.00% 13 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11210      +/-   ##
==========================================
- Coverage   33.25%   33.24%   -0.01%     
==========================================
  Files        2730     2730              
  Lines       85532    85545      +13     
  Branches    16314    16321       +7     
==========================================
  Hits        28443    28443              
- Misses      54831    54844      +13     
  Partials     2258     2258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Logo
Checkmarx One – Scan Summary & Details40ce2bdf-b1f6-46ec-b784-4ec2086a4f96

No New Or Fixed Issues Found

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may be potential to simplify this a bit, let me know what you think!

@Jingo88 Jingo88 added the needs-qa Marks a PR as requiring QA approval label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants