-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8836] Move ownership of biometrics to key-management #10818
Conversation
No New Or Fixed Issues Found |
.github/CODEOWNERS
Outdated
|
||
## Desktop native module ## | ||
apps/desktop/desktop_native @bitwarden/team-platform-dev | ||
|
||
## Key management team files ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10818 +/- ##
==========================================
- Coverage 33.27% 33.23% -0.05%
==========================================
Files 2731 2730 -1
Lines 85326 85258 -68
Branches 16229 16221 -8
==========================================
- Hits 28390 28332 -58
+ Misses 54678 54670 -8
+ Partials 2258 2256 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codeowners file contains typos.
Co-authored-by: Maciej Zieniuk <[email protected]>
Co-authored-by: Maciej Zieniuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a quick pass!
Co-authored-by: Maciej Zieniuk <[email protected]>
Co-authored-by: Maciej Zieniuk <[email protected]>
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8836
📔 Objective
Move ownership of biometrics on all platforms to key-management. This aims to not change any functionality. However we do break out a few parts (especially the biometrics handling in
desktop-credential-storage-listener.ts
). Actual refactor of these will come later.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes