Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8836] Move ownership of biometrics to key-management #10818

Merged
merged 29 commits into from
Sep 30, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Aug 30, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8836

📔 Objective

Move ownership of biometrics on all platforms to key-management. This aims to not change any functionality. However we do break out a few parts (especially the biometrics handling in desktop-credential-storage-listener.ts). Actual refactor of these will come later.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Logo
Checkmarx One – Scan Summary & Details4f622938-2505-4cc7-b6e0-1b5658e56cc4

No New Or Fixed Issues Found


## Desktop native module ##
apps/desktop/desktop_native @bitwarden/team-platform-dev

## Key management team files ##
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@quexten quexten marked this pull request as ready for review September 2, 2024 08:59
@quexten quexten requested review from a team as code owners September 2, 2024 08:59
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 72 lines in your changes missing coverage. Please review.

Project coverage is 33.23%. Comparing base (f1b343e) to head (59c8d5e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ment/biometrics/biometric.renderer-ipc.listener.ts 0.00% 30 Missing ⚠️
apps/desktop/src/key-management/preload.ts 0.00% 11 Missing ⚠️
...nagement/biometrics/electron-biometrics.service.ts 0.00% 7 Missing ⚠️
apps/desktop/src/main.ts 0.00% 5 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 2 Missing ⚠️
...anagement/biometrics/browser-biometrics.service.ts 0.00% 2 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 2 Missing ⚠️
apps/desktop/src/app/services/services.module.ts 0.00% 2 Missing ⚠️
apps/browser/src/auth/popup/lock.component.ts 0.00% 1 Missing ⚠️
...th/popup/settings/account-security-v1.component.ts 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10818      +/-   ##
==========================================
- Coverage   33.27%   33.23%   -0.05%     
==========================================
  Files        2731     2730       -1     
  Lines       85326    85258      -68     
  Branches    16229    16221       -8     
==========================================
- Hits        28390    28332      -58     
+ Misses      54678    54670       -8     
+ Partials     2258     2256       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten requested a review from a team September 4, 2024 13:31
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners file contains typos.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
mzieniukbw
mzieniukbw previously approved these changes Sep 4, 2024
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mzieniukbw
mzieniukbw previously approved these changes Sep 11, 2024
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a quick pass!

apps/desktop/src/main.ts Show resolved Hide resolved
justindbaur
justindbaur previously approved these changes Sep 16, 2024
apps/desktop/tsconfig.json Outdated Show resolved Hide resolved
@quexten quexten marked this pull request as draft September 23, 2024 08:46
@quexten quexten marked this pull request as ready for review September 23, 2024 10:46
@quexten quexten merged commit 19f547e into main Sep 30, 2024
55 checks passed
@quexten quexten deleted the km/pm-8836/move-biometrics-to-km-ownership branch September 30, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants