Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10570] Ensuring strategy exists before doing "in" check. Fixes "TypeError: C… #10387

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mcalmus
Copy link

@mcalmus mcalmus commented Aug 3, 2024

When session times out and "send verification code email again" link is clicked, the following error occurs and no feedback is given to user.

TypeError: Cannot use 'in' operator to search for 'email$' in null

This change ensure strategy object exists before calling "in".

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…annot use 'in' operator to search for 'email$' in null"
@mcalmus mcalmus requested a review from a team as a code owner August 3, 2024 17:54
@mcalmus mcalmus requested a review from rr-bw August 3, 2024 17:54
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-10570

@bitwarden-bot bitwarden-bot changed the title Ensuring strategy exists before doing "in" check. Fixes "TypeError: C… [PM-10570] Ensuring strategy exists before doing "in" check. Fixes "TypeError: C… Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants