Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1365] Fix organization ID not updating on overview swaps #10189

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

Thomas-Avery
Copy link
Contributor

@Thomas-Avery Thomas-Avery commented Jul 19, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1365

📔 Objective

This PR fixes a bug in the new menu component where organization ID wasn't being updated when swapping organizations on the overview page.

A similar error was occurring with the org suspended component, including the fix here.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this Jul 19, 2024
@Thomas-Avery Thomas-Avery requested a review from a team as a code owner July 19, 2024 16:59
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.88%. Comparing base (8a86a69) to head (b3c5995).

Files Patch % Lines
...c/app/secrets-manager/shared/new-menu.component.ts 0.00% 4 Missing ⚠️
.../secrets-manager/shared/org-suspended.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10189   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files        2644     2644           
  Lines       78848    78847    -1     
  Branches    14785    14783    -2     
=======================================
  Hits        25142    25142           
+ Misses      51796    51795    -1     
  Partials     1910     1910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsb73c45f4-58a2-48f3-aac9-9d790739c295

No New Or Fixed Issues Found

@Thomas-Avery Thomas-Avery added the needs-qa Marks a PR as requiring QA approval label Jul 19, 2024
@Thomas-Avery Thomas-Avery removed the needs-qa Marks a PR as requiring QA approval label Jul 26, 2024
@Thomas-Avery Thomas-Avery merged commit d4a1c1a into main Jul 26, 2024
16 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/sm-1365 branch July 26, 2024 21:06
quexten pushed a commit that referenced this pull request Aug 2, 2024
* fix org id not being updated in new-menu on org swaps

* fix org suspended component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants