[PM-8050] Deleting one folder deletes all other folders

[gbubemismith]

🎟️ Tracking

PM-8050

📔 Objective

Deleting a folder should not clear all folders on the client. There seems to be a malfunction with SyncService.syncDeleteFolder, which tries to sync the web client after a folder has been deleted on the web client. Previously, we returned when folders[id] == null, which clears the folder state.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 31.83183% with 227 lines in your changes missing coverage. Please review.

Project coverage is 31.66%. Comparing base (fd93c76) to head (3b6e6b4).
Report is 14 commits behind head on main.

Files	Patch %	Lines
...ryptography/bulk-encrypt.service.implementation.ts	0.00%	63 Missing ⚠️
...gistration-finish/registration-finish.component.ts	0.00%	32 Missing ⚠️
...assign-collections/assign-collections.component.ts	0.00%	27 Missing ⚠️
...ink-expired/registration-link-expired.component.ts	0.00%	15 Missing ⚠️
libs/common/src/vault/services/cipher.service.ts	16.66%	10 Missing ⚠️
libs/vault/src/cipher-form/cipher-form.stories.ts	0.00%	9 Missing ⚠️
...details-section/login-details-section.component.ts	88.31%	0 Missing and 9 partials ⚠️
...rgency-access/services/emergency-access.service.ts	36.36%	6 Missing and 1 partial ⚠️
...services/default-cipher-form-generation.service.ts	30.00%	6 Missing and 1 partial ⚠️
...bs/common/src/auth/services/account-api.service.ts	0.00%	6 Missing ⚠️
... and 20 more

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #10165    +/-   ##
========================================
  Coverage   31.66%   31.66%            
========================================
  Files        2620     2632    +12     
  Lines       78251    78546   +295     
  Branches    14676    14733    +57     
========================================
+ Hits        24780    24874    +94     
- Misses      51590    51777   +187     
- Partials     1881     1895    +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 9ce6074f-5240-4f10-a19a-2d5b360013b1

No New Or Fixed Issues Found

[shane-melton]

Nice catch on this bug! Just one unrelated question to the onDeletedFolder event emitter.

[shane-melton]

👍 Wow, nice catch on this one!