[PM-9855] Add premium badge to new file send item dropdown #10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
tools/pm-9851/create-sendv2-component-for-browser
to
main
July 16, 2024 21:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10137 +/- ##
=======================================
Coverage 31.59% 31.59%
=======================================
Files 2618 2618
Lines 78090 78090
Branches 14645 14645
=======================================
Hits 24670 24670
Misses 51551 51551
Partials 1869 1869 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
…s/pm-9855/add-premium-badge-to-new-file-send-dropdown
djsmith85
added
needs-qa
aj-rosado
approved these changes
Jul 18, 2024
djsmith85
deleted the
tools/pm-9855/add-premium-badge-to-new-file-send-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9855
📔 Objective
File Sends are a premium feature. If a user does not have premium, show a premium badge when selecting a new file send and when clicked direct the user to the premium page instead of the new Send page.
Testing will be done on main, as this is guarded behind a feature flag.
📸 Screenshots
Without premium
Screen.Recording.2024-07-16.at.23.00.31.mov
With premium
Screen.Recording.2024-07-16.at.23.05.49.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes