Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA Build Artifacts] Add translation for Add account option in account switcher #10072

Closed
wants to merge 1 commit into from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jul 11, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-9643

๐Ÿ“” Objective

PR to build artifacts for #10058

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@quexten quexten added the hold do not merge, do not approve yet label Jul 11, 2024
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 30.19%. Comparing base (3f0f5af) to head (5b179e7).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10072      +/-   ##
==========================================
+ Coverage   30.12%   30.19%   +0.06%     
==========================================
  Files        2576     2581       +5     
  Lines       75446    75523      +77     
  Branches    14113    14123      +10     
==========================================
+ Hits        22729    22805      +76     
+ Misses      50952    50950       -2     
- Partials     1765     1768       +3     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 109d0af3-d697-4472-9d11-4712fd868751

No New Or Fixed Issues Found

@quexten quexten changed the title [PR to build artifacts] Add translation for Add account option in account switcher [QA Build Artifacts] Add translation for Add account option in account switcher Jul 11, 2024
@quexten quexten closed this Jul 15, 2024
@djsmith85 djsmith85 deleted the community/pm-9643/add-account-i18n branch July 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants