Skip to content

Commit

Permalink
[PM-8833] Reworking how we handle adding a password to history
Browse files Browse the repository at this point in the history
  • Loading branch information
cagonzalezcs committed Sep 27, 2024
1 parent ab681e7 commit ef462a1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions apps/browser/src/autofill/background/overlay.background.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1512,6 +1512,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
*/
private async generatePassword(): Promise<void> {
this.generatedPassword = await this.generatePasswordCallback();
await this.addPasswordCallback(this.generatedPassword);
}

/**
Expand All @@ -1537,8 +1538,6 @@ export class OverlayBackground implements OverlayBackgroundInterface {
return;

Check warning on line 1538 in apps/browser/src/autofill/background/overlay.background.ts

View check run for this annotation

Codecov / codecov/patch

apps/browser/src/autofill/background/overlay.background.ts#L1538

Added line #L1538 was not covered by tests
}

await this.addPasswordCallback(this.generatedPassword);

const pageDetails = this.pageDetailsForTab[port.sender.tab.id];

Check warning on line 1541 in apps/browser/src/autofill/background/overlay.background.ts

View check run for this annotation

Codecov / codecov/patch

apps/browser/src/autofill/background/overlay.background.ts#L1541

Added line #L1541 was not covered by tests
if (!pageDetails) {
return;

Check warning on line 1543 in apps/browser/src/autofill/background/overlay.background.ts

View check run for this annotation

Codecov / codecov/patch

apps/browser/src/autofill/background/overlay.background.ts#L1543

Added line #L1543 was not covered by tests
Expand Down

0 comments on commit ef462a1

Please sign in to comment.