Skip to content

Commit

Permalink
[PM-12066] Add missing column headers to reports (#11293)
Browse files Browse the repository at this point in the history
* Add missing column header to weak-password report

* Add missing column header to exposed-password report

* Add missing column header to reused-password report

---------

Co-authored-by: Daniel James Smith <[email protected]>
  • Loading branch information
djsmith85 and djsmith85 authored Sep 27, 2024
1 parent b149c86 commit 20c253e
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
<th bitCell bitSortable="organizationId" *ngIf="!isAdminConsoleActive">
{{ "owner" | i18n }}
</th>
<th bitCell class="tw-text-right" bitSortable="exposedXTimes"></th>
<th bitCell class="tw-text-right" bitSortable="exposedXTimes">
{{ "timesExposed" | i18n }}
</th>
</tr>
</ng-container>
<ng-template body let-rows$>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<th bitCell></th>
<th bitCell>{{ "name" | i18n }}</th>
<th bitCell>{{ "owner" | i18n }}</th>
<th bitCell></th>
<th bitCell class="tw-text-right">{{ "timesReused" | i18n }}</th>
</tr>
</ng-container>
<ng-template body let-rows$>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@
<th bitCell bitSortable="organizationId" *ngIf="!isAdminConsoleActive">
{{ "owner" | i18n }}
</th>
<th bitCell class="tw-text-right" bitSortable="reportValue" default></th>
<th bitCell class="tw-text-right" bitSortable="reportValue" default>
{{ "weakness" | i18n }}
</th>
</tr>
</ng-container>
<ng-template body let-rows$>
Expand Down
9 changes: 9 additions & 0 deletions apps/web/src/locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2199,6 +2199,9 @@
"checkExposedPasswords": {
"message": "Check exposed passwords"
},
"timesExposed": {
"message": "Times exposed"
},
"exposedXTimes": {
"message": "Exposed $COUNT$ time(s)",
"placeholders": {
Expand Down Expand Up @@ -2233,6 +2236,9 @@
"noWeakPasswords": {
"message": "No items in your vault have weak passwords."
},
"weakness": {
"message": "Weakness"
},
"reusedPasswordsReport": {
"message": "Reused passwords"
},
Expand All @@ -2258,6 +2264,9 @@
"noReusedPasswords": {
"message": "No logins in your vault have passwords that are being reused."
},
"timesReused": {
"message": "Times reused"
},
"reusedXTimes": {
"message": "Reused $COUNT$ times",
"placeholders": {
Expand Down

0 comments on commit 20c253e

Please sign in to comment.