Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-13068 Navigate from settings to setup autofill screen. #4034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dseverns-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13068

๐Ÿ“” Objective

  • Navigate from the autofill settings to the setup autofill screen if there is the action card.
  • Show the setup autofill screen with "non root" UI and behavior.
  • This is the final piece to the badging related to the onboarding setup.

๐Ÿ“ธ Screenshots

pm13068.mp4

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 5e895340-ab6a-412e-98bd-b7e24b0d4d27

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant