Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-13019: Add special circumstance to navigate to the vault listing UI for TOTP code #4033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 4, 2024

🎟️ Tracking

PM-13019

πŸ“” Objective

This PR adds the special circumstance logic to route the user to the vault listing screen for a totp code intent.

Note that the Android Manifest has not bee updated to support this flow in this PR. That will occur in a future PR.

πŸ“Έ Screenshots

Screen_recording_20241004_132937.mp4

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One – Scan Summary & Details – 151ae728-7718-47c9-8a63-7a10685b5ee3

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (a5cf4f4) to head (9641163).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...en/ui/platform/feature/rootnav/RootNavViewModel.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4033   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         428      428           
  Lines       35199    35218   +19     
  Branches     5157     5162    +5     
=======================================
+ Hits        31292    31310   +18     
- Misses       2102     2103    +1     
  Partials     1805     1805           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant