PM-12322: Update color scheme #3986
Conversation
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
david-livefront
force-pushed
the
PM-12322-update-color-scheme
branch
from
d76ba8d
to
81faf9e
Compare
|
Wow...dark mode is |
| @@ -323,7 +323,7 @@ fun ExampleScreen( | |||
| text = state.exampleData, | |||
| textAlign = TextAlign.Center, | |||
| style = MaterialTheme.typography.headlineSmall, | |||
| color = MaterialTheme.colorScheme.onSurface, | |||
| color = BitwardenTheme.colorScheme.textColors.primary, | |||
There was a problem hiding this comment.
May be overkill and definitely outside the scope of this PR. It may be a good idea to just call out the use of Material components and how we are creating this pattern of mapping them for some of those components like radio buttons/cards/etc. component somewhere in the Readme
| @@ -0,0 +1,89 @@ | |||
| package com.x8bit.bitwarden.ui.platform.components.field.color | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
==========================================
+ Coverage 88.90% 88.91% +0.01%
==========================================
Files 425 425
Lines 35145 35150 +5
Branches 5147 5145 -2
==========================================
+ Hits 31245 31254 +9
+ Misses 2108 2104 -4
Partials 1792 1792 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I am in awe that you got this done this fast. Standing desk ovation to ya. I feel like this will work great as it still leaves the options in the future to support custom themes and with a non insignificant collaborative effort with design could even support a partial Material You experience (maybe even before google deprecates it)
david-livefront
force-pushed
the
PM-12322-update-color-scheme
branch
2 times, most recently
from
3b0bc72
to
2725e0f
Compare
| <color name="ic_launcher_background">@color/blue_175DDC</color> | ||
| <color name="ic_shortcut_background">@color/white</color> | ||
| <!-- This is the apps Primary Blue color an exists here for launcher and splash theme only --> | ||
| <color name="ic_launcher_background">#FF175DDC</color> |
There was a problem hiding this comment.
This one is a little interesting, we need the color to be defined in XML for both the launcher icon and the splash theme. This is the only color in the app that needs to be defined in XML.
david-livefront
force-pushed
the
PM-12322-update-color-scheme
branch
14 times, most recently
from
1380e16
to
a229d85
Compare
david-livefront
force-pushed
the
PM-12322-update-color-scheme
branch
from
a229d85
to
f2daea7
Compare
|
Thanks @dseverns-livefront |
🎟️ Tracking
PM-12322
📔 Objective
This PR adds the new
BitwardenThemeand applies the new colorscheme to the entire app.📸 Screenshots
colorscheme.mp4