Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10678] Display all passkeys and accounts in OS prompt #3941

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Sep 19, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10678

📔 Objective

Extract credential selection and authentication to a dedicated View.

📸 Screenshots

Scenario Before After
All accounts locked Cell image
All accounts locked (Sign-in options) Cell image
All accounts unlocked Cell image
All accounts unlocked (Sign-in options) Cell image
Checked all accounts Cell image
Checked all accounts (Sign-in options) Cell image
User verification Cell image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Logo
Checkmarx One – Scan Summary & Details0829ee5f-c2ea-4334-87b1-f29ba0d7fc17

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck marked this pull request as draft September 19, 2024 15:02
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 68.47361% with 221 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (f26374a) to head (3c616c8).

Files with missing lines Patch % Lines
...m/x8bit/bitwarden/ui/autofill/fido2/Fido2Screen.kt 0.00% 95 Missing ⚠️
.../ui/autofill/fido2/handlers/Fido2DialogHandlers.kt 0.00% 38 Missing ⚠️
...8bit/bitwarden/ui/autofill/fido2/Fido2ViewModel.kt 93.87% 11 Missing and 13 partials ⚠️
...i/auth/feature/vaultunlock/VaultUnlockViewModel.kt 36.11% 19 Missing and 4 partials ⚠️
...ll/fido2/handlers/Fido2UserVerificationHandlers.kt 0.00% 21 Missing ⚠️
...fill/fido2/processor/Fido2ProviderProcessorImpl.kt 83.92% 4 Missing and 5 partials ⚠️
...tofill/fido2/manager/Fido2CompletionManagerImpl.kt 63.63% 8 Missing ⚠️
...n/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3941      +/-   ##
==========================================
- Coverage   88.85%   88.42%   -0.43%     
==========================================
  Files         425      429       +4     
  Lines       34949    35451     +502     
  Branches     5114     5185      +71     
==========================================
+ Hits        31055    31349     +294     
- Misses       2112     2303     +191     
- Partials     1782     1799      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant