Fixing possible range for week_of_month type #704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Pretty straightforward change to make the type specification match the actual possible outputs from the existing function. See #703 for full details, but in summary the
week_of_month
function can return values up to 6, but the type currently specifies that it should return a value between 1 and 5.January 2022 Calendar:
I searched through the application, and this function (
Timex.week_of_month
) was the only place where this type is being used.Checklist