BSIP 48 Add flag to prevent asset's max supply from being changed #115
Conversation
|
|
||
| The `disable_modify_max_supply` is a new created flag in the `asset_issuer_permissions`. | ||
| The flag can be activated to forbid the modification of the `max_supply` (`asset_object.options`). | ||
| Once the flag is activated, it can't be deactivated. |
There was a problem hiding this comment.
If it can't be deactivated, why not set it as an issuer_permission?
There was a problem hiding this comment.
Note: permissions can be modified when current_supply = 0. Makes sense also in this case IMO.
There was a problem hiding this comment.
@pmconrad Indeed, I will add that behaviour.
| 2. Add a `can_modify_max_supply()` the `asset_object` | ||
| 3. Change the `asset_update_evaluator::evaluate` method to assert false for | ||
| 1. the deactivation of the `disable_modify_max_supply` flag | ||
| 2. the modification of the `max_supply` when the `disable_modify_max_supply` is set |
There was a problem hiding this comment.
Good call, I would recommend the permission is enabled, as is the flag.
That way, behavior isn't changed.
The feature is supposed to be opt-out afterall.
What needs to be done to ensure that for existing assets?
abitmore
changed the title
| # Rational | ||
|
|
||
| The `disable_modify_max_supply` is a new created flag in the `asset_issuer_permissions`. | ||
| The flag can be activated to forbid the modification of the `max_supply` (`asset_object.options`). |
There was a problem hiding this comment.
IMO the flag is easier to understand if it is called allow_modify_max_supply, i. e. the meaning is inverted.
There was a problem hiding this comment.
Discussion in bitshares/bitshares-core#1375 (review) suggests the opposite.
|
Btw, number 48 may have already been assigned to STEALTH, please coordinate. @ryanRfox ? |
|
Any progress toward advancing this? |
This is a new proposal that adds a flag to the asset permissions.
This flag allows to opt out of "changing the max supply".