Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardfork] Added disable_modify_max_supply flag #1612

Conversation

xeroc
Copy link
Member

@xeroc xeroc commented Feb 22, 2019

This pull request collides with #1611 as it uses the same value for the flag.

This feature introduces a flag that prevents issues from changing the max_supply of an asset.
Obviously, for this flag to make sense, the issuer would need to also disable the corresponding permission.

A BSIP for this PR will follow shortly
(paging @Dimfred)

@xeroc
Copy link
Member Author

xeroc commented Feb 22, 2019

BSIP here:
bitshares/bsips#147

The only thing (as can be seen from the BSIP) that I am unaware about is:
How to deal with existing assets. I assume that we have to predefine the value for the new flag/permission to be one. Is there any reason not to do that in db_init?

@pmconrad
Copy link
Contributor

Can we close #1375 then?

@xeroc
Copy link
Member Author

xeroc commented Feb 22, 2019

Can we close #1375 then?

Oh my ... I am sorry, totally forgot about the open pull request. Will move the improvements to the other open pull request where discussion already took place. closing this one

@xeroc xeroc closed this Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants