Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check LD_LIBRARY_PATH on setup #580

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gembancud
Copy link

Issue:
Instructions when compiling to source require setting the destination of binaries in env var LD_LIBRARY_PATH.
This env is not checked during library setup, so unshipped self-compiled binaries will remain undetected.
Soln:
Adds a check to LD_LIBRARY PATH.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this Dec 30, 2023
@TimDettmers
Copy link
Collaborator

I have to check this more carefully when I have more time. Thank you for your contribution! Sorry for taking so long to look at this.

@TimDettmers TimDettmers reopened this Jan 1, 2024
@TimDettmers TimDettmers added medium priority (will be worked on after all high priority issues) Medium risk Risk of bugs in transformers and other libraries labels Jan 1, 2024
@Titus-von-Koeller Titus-von-Koeller self-assigned this Jan 25, 2024
@akx
Copy link
Contributor

akx commented Feb 9, 2024

Related: #1041 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority (will be worked on after all high priority issues) Medium risk Risk of bugs in transformers and other libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants